Fixed bug #81096: Inconsistent range inferece for variables passed by reference #7121
Conversation
|
I think the general approach here is okay. However, it is easy to cause discrepancies between this reference inference and type inference. I've prepared https://gist.github.com/nikic/c0a903adace7272b64a60e9b36cf0a31 to add a consistency assertion and fix handling for a few opcodes I found this way (for PRE_INC/DEC the error was on the type inference side, I fixed that separately). Note that currently this assertions is broken when type inference is called from tracing JIT, as the reference inference doesn't happen there. I'm not sure whether the original problem also affects the JIT inference -- do we need to perform something similar to zend_mark_cv_references there as well? |
|
@nikic Thanks for corrections, I'll update the PR soon. In tracing JIT we don't perform range inference. We only copy ranges inferred on function SSA. |
… reference Detect references before range inference and exclude them from range inference.
|
@nikic please take a quick look into the last commit. I hope, everything should be fine now. |
|
Merged as 7368d0c |
This issue is properly fixed by GH-7121 on master. For older branches, disable the use of range information in SCCP, to reduce impact of potentially incorrect ranges.
Detect references before range inference and exclude them from range inference.